-
Notifications
You must be signed in to change notification settings - Fork 170
Adding MacOS E2E Testing to CI Pipeline #1903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MacOS E2E Testing to CI Pipeline #1903
Conversation
|
Would like to hold this one till #1535 merges. Just had our sync and I'll try to get that merged ASAP, aka this week. |
Definitely, was planning on waiting. Just wanted to test the CI to make sure we only run this for MacOS and not iOS. The matrix part of the pipeline is a bit confusing to me, but I'm working on it :) |
.ado/azure-pipelines.yml
Outdated
| parameters: | ||
| relative_directory: $(relative_directory) | ||
|
|
||
| # - ${{ if eq(variables[relative_directory], 'macos')}}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YML is hard to verify. locally so most likely you'll see a lot of small commits to try and debug the yml till it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing. Will mark this PR as a draft until I get it down
.ado/azure-pipelines.yml
Outdated
| - bash: echo Test 2 | ||
| condition: and(succeeded(), eq($(relative_directory), macos)) | ||
|
|
||
| - bash: echo Test 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are we testing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to remove this code, I just needed to test what syntax would work for certain conditions. I'm going to mark this PR as a draft until I figure it out :)
…tive into macosE2ECIPipeline # Conflicts: # .ado/azure-pipelines.yml # apps/fluent-tester/wdio.conf.macos.js # apps/macos/package.json
…he macos e2e testing
Platforms Impacted
Description of changes
Adding MacOS E2E Testing to CI Pipeline
Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered (when applicable):