Skip to content

Conversation

@samuelfreiberg
Copy link
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Adding MacOS E2E Testing to CI Pipeline

Verification

(how the change was tested, including both manual and automated tests)

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@samuelfreiberg samuelfreiberg requested a review from a team as a code owner July 25, 2022 19:06
@Saadnajmi
Copy link
Collaborator

Would like to hold this one till #1535 merges. Just had our sync and I'll try to get that merged ASAP, aka this week.

@samuelfreiberg
Copy link
Contributor Author

Would like to hold this one till #1535 merges. Just had our sync and I'll try to get that merged ASAP, aka this week.

Definitely, was planning on waiting. Just wanted to test the CI to make sure we only run this for MacOS and not iOS. The matrix part of the pipeline is a bit confusing to me, but I'm working on it :)

parameters:
relative_directory: $(relative_directory)

# - ${{ if eq(variables[relative_directory], 'macos')}}:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YML is hard to verify. locally so most likely you'll see a lot of small commits to try and debug the yml till it works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing. Will mark this PR as a draft until I get it down

- bash: echo Test 2
condition: and(succeeded(), eq($(relative_directory), macos))

- bash: echo Test 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are we testing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove this code, I just needed to test what syntax would work for certain conditions. I'm going to mark this PR as a draft until I figure it out :)

…tive into macosE2ECIPipeline

# Conflicts:
#	.ado/azure-pipelines.yml
#	apps/fluent-tester/wdio.conf.macos.js
#	apps/macos/package.json
@samuelfreiberg samuelfreiberg marked this pull request as draft July 25, 2022 21:53
@samuelfreiberg samuelfreiberg deleted the macosE2ECIPipeline branch September 8, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants