Introduce .node-version file #2624
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
https://github.com/shadowspawn/node-version-usage
While there isn't an "official" way to specify a node version per repo, several node version managers have adopted using a
.node-versionfile. React Native Core for example, also uses this file. Let's introduce that here, and update our CI to reference it so it's easier to bump node in the future.This change also updates us to Node 16, as well as removes a stale
ymlfile that is probably a relic from when this repo was closed source.Verification
CI should pass.
Pull request checklist
This PR has considered (when applicable):