chore: migrate to eslint v9 #33527
Merged
chore: migrate to eslint v9 #33527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricteam
reviewed
Dec 30, 2024
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
mainframev
force-pushed
the
eslint-v9-with-flag
branch
3 times, most recently
from
c6b91dd to
a8bd13f
Compare
📊 Bundle size report✅ No changes found |
mainframev
force-pushed
the
eslint-v9-with-flag
branch
2 times, most recently
from
cc6f3e3 to
c71d536
Compare
|
Pull request demo site: URL |
mainframev
force-pushed
the
eslint-v9-with-flag
branch
2 times, most recently
from
889a93b to
e1a4584
Compare
mainframev
force-pushed
the
eslint-v9-with-flag
branch
3 times, most recently
from
eb15a30 to
df1d6c8
Compare
fabricteam
reviewed
Feb 12, 2025
mainframev
force-pushed
the
eslint-v9-with-flag
branch
3 times, most recently
from
987ce1b to
0d3f32f
Compare
mainframev
requested review from
a team,
GeoffCoxMSFT,
behowell,
dzearing and
spmonahan
as code owners
…act-hooks chore(fabric): suppress deprecation errors chore: suppress deprecation errors chore: remove odd addition
…our of just-scripts option
mainframev
force-pushed
the
eslint-v9-with-flag
branch
from
06adaef to
6258a79
Compare
Hotell
reviewed
Apr 3, 2025
Hotell
reviewed
Apr 3, 2025
| "@typescript-eslint/no-explicit-any": "off", | ||
| "no-restricted-globals": "off" | ||
| "no-restricted-globals": "off", | ||
| "@typescript-eslint/no-deprecated": "warn" |
Contributor
There was a problem hiding this comment.
Hotell
reviewed
Apr 3, 2025
| "import/no-webpack-loader-syntax": "off", // ok in this project | ||
| "no-restricted-globals": "off" | ||
| "no-restricted-globals": "off", | ||
| "react-hooks/rules-of-hooks": "warn" |
Contributor
There was a problem hiding this comment.
Hotell
approved these changes
Apr 3, 2025
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 8, 2025
mainframev
added a commit
to mainframev/fluentui
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to ESLint v9 but sticking with the legacy config format for now. Jumping straight to the new flat format is too much all at once. The plan is to first update ESLint with legacy flag and all related plugins to make sure everything works. After that, will start moving our .eslintrc files over to eslint.config.js and switch to the new flat format
In follow-up internal
eslint-pluginwill be moved to flat config,eslint-plugin-react-componentswill be compatible with both 8 and 9 versions.Previous Behavior
New Behavior
Related Issue(s)