[Fix] node version to be compatible with CEM analyzer so parsedTypes get properly written. #35277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get properly written.
marchbox
approved these changes
Oct 3, 2025
davatron5000
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
pixel-perfectionist
pushed a commit
to pixel-perfectionist/fluentui
that referenced
this pull request
Oct 8, 2025
…get properly written. (microsoft#35277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The node version was causing the CEM analyzer to not write optional enum attributes to the parsedTypes to the CEM output. Based on the current file structure in the web-components package there was no way for it to properly parse them using the option indicator i.e @attr appearance?: ButtonAppearance. Defaulting the value or decortaing it with a required ! fixed the problem but this is not a viable solution. Also keeping the attribute optional ? and defining the enum types inline above the class solved the issue however this is a major refactor and does not follow best practices. This fact pointing the the likelihood of a import issues and typescript. Ultimately updating the node version solved the issue
New Behavior
Optional enum attributes now have there parsedTypes written to the CEM.
Related Issue(s)