Switching Enum.HasFlag calls with bitwise operations

[TalZaccai]

Switching a few areas in the code from using Enum.HasFlag (which apparently uses reflection and thus incur overhead) to using more efficient bitwise operations.

[PaulusParssinen]

Enum.HasFlag has been intrinsic since 2017. The codegen should be same as bitwise check. It doesn't have to do reflection if the call HasFlag call targets the generic overload. I suggest reverting this PR.

[TalZaccai]

Enum.HasFlag has been intrinsic since 2017. The codegen should be same as bitwise check. It doesn't have to do reflection if the call HasFlag call targets the generic overload. I suggest reverting this PR.

Interesting... I've definitely seen unnecessary allocations when running a profiler, which I don't see any longer, so I'm not sure why that would be the case.

[PaulusParssinen]

Interesting... I've definitely seen unnecessary allocations when running a profiler, which I don't see any longer, so I'm not sure why that would be the case.

It shouldn't be boxing in even in debug mode or Tier-0 codegen anymore (I could be wrong here). But if there clearly is difference with profiler runs I think the changes should then stay. It definitely gets eliminated in Tier-1 (i.e. fully optimized hot code) 😅

update: checked few places, the change that optimized HasFlag for tier-0 (i.e. unoptimized code) was reverted shortly after due to some concerns. I think this change is good after all. A static HasFlag helper to do this bitwise could be useful in future.

[TalZaccai]

That's good to know! Thanks for looking into it!