send-pack: build list of oids to sent to pack-objects #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhostetler
approved these changes
Mar 5, 2019
jeffhostetler
left a comment
jeffhostetler
left a comment
There was a problem hiding this comment.
Looks good.
I do wonder if it would be faster to build a single large
strbuf and then fwrite() the whole thing at the child process
rather than feeding it a line at a time.
But that's a bigger change. Feel free to ignore.
kewillford
referenced
this pull request
Mar 6, 2019
|
@kewillford are you still working on this PR and/or #79? |
Member
Author
|
@derrickstolee Nope this was fixed with #128 which went upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #68 because it was causing issues with pushing to other remotes.
This change builds the list of oids before
pack-objectsis spawned so that if checking for the oid has to download the object via theread-objectprocess the stdin and stdout handles will not get handled incorrectly.The one disadvantage of this change is it will take more memory especially when there are a lot of objects to be pushed since it is building the full list first.
Another possible fix is #79 to fix handle inheritance but that change is a lot more invasive and could affect other commands. This change will limit the scope to push.