Skip to content

[VFS] upload-pack: fix race condition in error messages #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derrickstolee merged 1 commit into from
Aug 28, 2019
Merged

[VFS] upload-pack: fix race condition in error messages #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions upload-pack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,11 +613,12 @@ static void check_non_tip(struct object_array *want_obj,
for (i = 0; i < want_obj->nr; i++) {
struct object *o = want_obj->objects[i].item;
if (!is_our_ref(o)) {
warning("git upload-pack: not our ref %s",
oid_to_hex(&o->oid));
packet_writer_error(writer,
"upload-pack: not our ref %s",
oid_to_hex(&o->oid));
die("git upload-pack: not our ref %s",
oid_to_hex(&o->oid));
exit(1);
}
}
}
Expand Down