Skip to content

Disable git update-git-for-windows #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dscho merged 1 commit into from
Feb 4, 2020
Merged

Disable git update-git-for-windows #243

dscho merged 1 commit into from
Feb 4, 2020

Conversation

@dscho
Copy link
Member

@dscho dscho commented Feb 4, 2020

This addresses #241

@dscho dscho requested a review from derrickstolee February 4, 2020 18:49
@dscho dscho force-pushed the disable-update-gfw branch from b47c509 to 29e756b Compare February 4, 2020 20:45
derrickstolee
derrickstolee approved these changes Feb 4, 2020
View reviewed changes
Copy link

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! So by making git update an actual builtin, the script version from git-for-windows/build-extra will never be visible? That seems like a good approach.

jrbriggs
jrbriggs approved these changes Feb 4, 2020
View reviewed changes
@dscho
Copy link
Member Author

dscho commented Feb 4, 2020

by making git update an actual builtin, the script version from git-for-windows/build-extra will never be visible?

Yep ;-)

@dscho
vfs: disable git update-git-for-windows
b114c34 
If a user runs git update-git-for-windows, then they will upgrade to a
version that does not support microsoft/vfsforgit or microsoft/scalar.

Therefore, let's prevent this.

This addresses microsoft#241
@dscho dscho force-pushed the disable-update-gfw branch from 29e756b to b114c34 Compare February 4, 2020 21:06
@dscho dscho merged commit 9bf9e08 into microsoft:vfs-2.25.0 Feb 4, 2020
@dscho dscho deleted the disable-update-gfw branch February 4, 2020 23:32
@dscho dscho mentioned this pull request Feb 4, 2020
Closed
derrickstolee added a commit to derrickstolee/scalar that referenced this pull request Feb 5, 2020
@derrickstolee
Update Git to include disabled fetch-pack
4f8808f 
See microsoft/git#240 and microsoft/git#243.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee derrickstolee mentioned this pull request Feb 5, 2020
Merged
derrickstolee added a commit to microsoft/scalar that referenced this pull request Feb 5, 2020
@derrickstolee
Merge pull request #321: Update Git to v2.25.0.vfs.1.3 to include dis…
4af1ea5 
…abled fetch-pack and block 'git update'

See microsoft/git#240 and microsoft/git#243.

Because of #320, we do not need to update the minimum Git version from `v2.25.0.vfs.1.1` even though we are packaging with `v2.25.0.vfs.1.3` now.
derrickstolee pushed a commit that referenced this pull request Feb 21, 2020
@dscho @derrickstolee
Merge pull request #243 from dscho/disable-update-gfw
e1d0adf 
Disable `git update-git-for-windows`
derrickstolee pushed a commit that referenced this pull request Mar 17, 2020
@dscho @derrickstolee
Merge pull request #243 from dscho/disable-update-gfw
9e36c9d 
Disable `git update-git-for-windows`
derrickstolee pushed a commit that referenced this pull request Mar 23, 2020
@dscho @derrickstolee
Merge pull request #243 from dscho/disable-update-gfw
4fe06db 
Disable `git update-git-for-windows`
dscho added a commit that referenced this pull request May 20, 2020
@dscho
Merge pull request #243 from dscho/disable-update-gfw
ecf552c 
Disable `git update-git-for-windows`
dscho added a commit that referenced this pull request May 20, 2020
@dscho
Merge pull request #243 from dscho/disable-update-gfw
63a21ac 
Disable `git update-git-for-windows`
derrickstolee pushed a commit that referenced this pull request Jun 1, 2020
@dscho @derrickstolee
Merge advanced VFS-specific features
17a768d 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit that referenced this pull request Jul 18, 2020
@dscho @derrickstolee
Merge advanced VFS-specific features
7aa3f7a 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit that referenced this pull request Jul 27, 2020
@dscho @derrickstolee
Merge advanced VFS-specific features
92441f8 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit that referenced this pull request Jul 28, 2020
@dscho @derrickstolee
Merge advanced VFS-specific features
0440c48 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit that referenced this pull request Oct 6, 2020
@dscho @derrickstolee
Merge advanced VFS-specific features
6cf43ec 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Dec 17, 2024
@dscho
Merge advanced VFS-specific features
f5267ae 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Dec 18, 2024
@dscho
Merge advanced VFS-specific features
7822df9 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jan 1, 2025
@dscho
Merge advanced VFS-specific features
ea88e02 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jan 1, 2025
@dscho
Merge advanced VFS-specific features
668aeb8 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Feb 10, 2025
@dscho
Merge advanced VFS-specific features
fbc2654 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Feb 27, 2025
@dscho
Merge advanced VFS-specific features
a3a78ea 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Mar 5, 2025
@dscho
Merge advanced VFS-specific features
83f614a 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham pushed a commit that referenced this pull request Mar 12, 2025
@dscho @mjcheetham
Merge advanced VFS-specific features
19d49cd 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham pushed a commit that referenced this pull request Mar 17, 2025
@dscho @mjcheetham
Merge advanced VFS-specific features
d5e171a 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jun 6, 2025
@dscho
Merge advanced VFS-specific features
a1c4fb0 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jun 11, 2025
@dscho
Merge advanced VFS-specific features
7cc394b 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jun 13, 2025
@dscho
Merge advanced VFS-specific features
ac4626c 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jun 16, 2025
@dscho
Merge advanced VFS-specific features
f343187 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jun 16, 2025
@dscho
Merge advanced VFS-specific features
0a660fa 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jun 16, 2025
@dscho
Merge advanced VFS-specific features
fbea14d 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jul 8, 2025
@dscho
Merge advanced VFS-specific features
a2392e3 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Aug 5, 2025
@dscho
Merge advanced VFS-specific features
3dc2239 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Aug 5, 2025
@dscho
Merge advanced VFS-specific features
beac86b 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Aug 8, 2025
@dscho
Merge advanced VFS-specific features
bba902c 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Aug 8, 2025
@dscho
Merge advanced VFS-specific features
8894896 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Aug 13, 2025
@dscho
Merge advanced VFS-specific features
b42bcf8 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Aug 19, 2025
@dscho
Merge advanced VFS-specific features
38e190a 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Oct 17, 2025
@dscho
Merge advanced VFS-specific features
376f7ec 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Oct 17, 2025
@dscho
Merge advanced VFS-specific features
eb256d7 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Oct 28, 2025
@dscho
Merge advanced VFS-specific features
2a604a9 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 5, 2025
@dscho
Merge advanced VFS-specific features
3957dda 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 6, 2025
@dscho
Merge advanced VFS-specific features
a3d85b8 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 6, 2025
@dscho
Merge advanced VFS-specific features
5c64b6d 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 13, 2025
@dscho
Merge advanced VFS-specific features
9e33ebc 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 17, 2025
@dscho
Merge advanced VFS-specific features
ceaf70e 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derrickstolee derrickstolee derrickstolee approved these changes

+1 more reviewer

@jrbriggs jrbriggs jrbriggs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dscho @derrickstolee @jrbriggs