Use Azure Federated login mechanism rather than secrets #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use federated authentication with GitHub Actions and Azure Entra ID for the Azure login commands during build-git-installers.yml builds. This will allow us to drop the use of a client secret to authenticate as the signing identity for Trusted Code Signing. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
vdye
approved these changes
Jun 24, 2024
vdye
left a comment
vdye
left a comment
There was a problem hiding this comment.
This change is nice and simple, and keeps us from needing the credential secret. Good stuff!
dscho
added a commit
that referenced
this pull request
Jul 17, 2024
Use federated authentication with GitHub Actions and Azure Entra ID for the Azure login commands during `build-git-installers.yml` builds. This will allow us to drop the use of a client secret to authenticate as the signing identity for Trusted Code Signing. The `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_SUBSCRIPTION_ID` secrets have already been added to the `release` environment, and a test of the `azure/login` step using this mechanism and a subsequent `az` command has been successfully demonstrated here: https://github.com/microsoft/git/actions/runs/9652892561/job/26624014573
dscho
added a commit
that referenced
this pull request
Jul 17, 2024
Use federated authentication with GitHub Actions and Azure Entra ID for the Azure login commands during `build-git-installers.yml` builds. This will allow us to drop the use of a client secret to authenticate as the signing identity for Trusted Code Signing. The `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_SUBSCRIPTION_ID` secrets have already been added to the `release` environment, and a test of the `azure/login` step using this mechanism and a subsequent `az` command has been successfully demonstrated here: https://github.com/microsoft/git/actions/runs/9652892561/job/26624014573
dscho
added a commit
that referenced
this pull request
Jul 17, 2024
Use federated authentication with GitHub Actions and Azure Entra ID for the Azure login commands during `build-git-installers.yml` builds. This will allow us to drop the use of a client secret to authenticate as the signing identity for Trusted Code Signing. The `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_SUBSCRIPTION_ID` secrets have already been added to the `release` environment, and a test of the `azure/login` step using this mechanism and a subsequent `az` command has been successfully demonstrated here: https://github.com/microsoft/git/actions/runs/9652892561/job/26624014573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use federated authentication with GitHub Actions and Azure Entra ID for the Azure login commands during
build-git-installers.ymlbuilds.This will allow us to drop the use of a client secret to authenticate as the signing identity for Trusted Code Signing.
The
AZURE_CLIENT_ID,AZURE_TENANT_ID, andAZURE_SUBSCRIPTION_IDsecrets have already been added to thereleaseenvironment, and a test of theazure/loginstep using this mechanism and a subsequentazcommand has been successfully demonstrated here: https://github.com/microsoft/git/actions/runs/9652892561/job/26624014573