Fix type mismatch in DynamicCommunitySelection children lookup#2124
Closed
KeonhoChu wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix type mismatch in DynamicCommunitySelection children lookup#2124KeonhoChu wants to merge 1 commit intomicrosoft:mainfrom
KeonhoChu wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
gaudyb
approved these changes
Dec 29, 2025
This was referenced Dec 29, 2025
Author
|
Thanks for addressing this in #2159! I'm glad my idea in this PR helped resolve the issue. I'll close this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a type mismatch bug in
DynamicCommunitySelectionthat prevented the algorithm from correctly traversing child communities during global search queries withdynamic_community_selection=True.Related Issues
Fixes #2004
Proposed Changes
dynamic_community_selection.py(lines 125-129)self.communities[community].childrenwere not matching keys inself.reportsdictionary due to type inconsistencystr(child)) to ensure child IDs match theself.reportskey typeRoot Cause:
Community.childrencontains IDs that may be loaded as integersCommunityReport.community_idis defined asstrtypeself.reportsdictionary is keyed bycommunity_id(strings)if child in self.reportsalways failed, causing all child communities to be skippedImpact:
Checklist