You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am pretty sure I never merged this PR and there is no need to revert it. When I was making changes for #1021 I made them on the same branch (storage_spaces) by rebasing it locally and then I pushed the new commit to a new branch (scsi_vsmb_fix) and also pushed this (storage_spaces) branch and changed this PR to draft because I still wanted to push new changes here. However, it looks like github automatically changed the status of this PR from draft to merged when I merged #1021 because both of these branches have the same commit at top. The diff of this merged PR only shows changes that are exactly the same as #1021 so there is no need to revert anything.
I guess if I push new changes to storage_spaces branch then github might automatically change the status of that PR back to open or if not I can open another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #998
Not sure how this got merged. I must have merged this by mistake while trying to merge the other PR #1021