Build only on windows.

[erikh]

Over at github.com/containers/ I'm trying to incorporate various parts of docker which leverage this library. I am building on linux.

The references to go-winio do not build on linux because they have a build tag which demands windows. This library leverages go-winio, but does not have the appropriate build tags itself, which causes it to build with undefined symbols. This is unfortunately halting our test suite as a result.

Please let me know if this is unacceptable, how I can make it acceptable.

Thanks!

cc @runcom @mtrmac

[msftclas]

Hi @erikh, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[erikh]

signed

[lowenna]

Do you not need an 'unsupported.go' file that is !windows?

[erikh]

seems to build fine without it (the relevant portions are gated by something else I assume)

…

On Sun, Jan 22, 2017 at 10:04 PM, John Howard ***@***.***> wrote: ***@***.**** commented on this pull request. Do you not need an 'unsupported.go' file that is !windows? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#106 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABJ64YJJbyzznPkuB85UyzV7ed2DDQSks5rVELggaJpZM4Lqr24> .

[msftgits]

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

[msftclas]

Hi @erikh, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

[lowenna]

I don't think this file should be updated as it's autogenerated

[erikh]

Does this contain windows only code? If so, we should keep it from compiling.

go generate should not affect the build tag.

[erikh]

Oh I see. I'll fix it.

[erikh]

Added it to the generator to get the best of both worlds. I have manually edited the generated source still, but it should reflect the generated version. Can you test for me? I don't have a windows development environment atm (but fwiw, I do all my hacking on linux on windows 10 :)

[lowenna]

@erikh - Can I ask why you're even pulling a Windows-only library into Linux code though? Questioning whether making this change is really the right thing to do, and it just simply shouldn't be used on non-Windows platforms.

[erikh]

I believe the requirement comes from docker, but I'll double check.

[erikh]

Is there a practical disadvantage to doing this?

[m-kostrzewa]

@erikh FYI it builds on Windows, haven't verified if it works.

[lowenna]

I'm closing this for now. I can't think why a Windows-specific library would need to be included in Linux, and haven't seen anything convincing to warrant updating this.