Unlock google.golang.org/grpc#1177
Draft
TBBle wants to merge 1 commit intomicrosoft:mainfrom
Draft
Conversation
TBBle
force-pushed
the
unlock-grpc-version
branch
from
0e15f1f to
aeabdd3
Compare
Contributor
Author
Contributor
Author
|
For future work, #1302 has pointed out that containerd/ttrpc#92 has an overarching issue at containerd/containerd#6564 which might be clearer about how to migrate away from |
This was originally locked in microsoft#1000 based on containerd's resolution for containerd/ttrpc#62. However, this was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us. See also containerd/ttrpc#89, which documents that only google.golang.org/genproto needs to be locked. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
Contributor
Author
|
Rebased onto master, incorporating #1302 so protobuf regeneration is now documented and verified in GitHub Actions. containerd/containerd#6564 has been closed by merge of containerd/containerd#6841 (and also containerd/containerd#6867 is a relevant follow-up) which still carries the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally locked in #1000 based on containerd's resolution for containerd/ttrpc#62. However, the lock on
google.golang.org/grpcwas dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us, while the lock ongoogle.golang.org/genprotowas kept.See also containerd/ttrpc#89, which intended to document that only
google.golang.org/genprotoneeds to be locked. However, this PR was dropped in favour of containerd/ttrpc#92, droppinggogo/protobufentirely (somehow).Draft because: