Skip to content

Add LCOW /dev/shm size runhcs option#1190

Closed
anmaxvl wants to merge 2 commits intomicrosoft:masterfrom
anmaxvl:lcow-shm-size-runhcs-option
Closed

Add LCOW /dev/shm size runhcs option#1190
anmaxvl wants to merge 2 commits intomicrosoft:masterfrom
anmaxvl:lcow-shm-size-runhcs-option

Conversation

@anmaxvl
Copy link
Copy Markdown
Contributor

@anmaxvl anmaxvl commented Oct 6, 2021

Add new const annotation AnnotationLCOWDevShmSizeInKb for setting the
default size for /dev/shm in LCOW scenarios. Replace existing hardcoded
references with the new const. Overwrite container spec whenever the
annotation is present.

Depends on #1201

@dcantah
Copy link
Copy Markdown
Contributor

dcantah commented Oct 6, 2021

Well this is sad, it seems to be crying because you're using the oci package in the guest and it pulls in some other imports that are Windows only?

@anmaxvl
Copy link
Copy Markdown
Contributor Author

anmaxvl commented Oct 6, 2021

Well this is sad, it seems to be crying because you're using the oci package in the guest and it pulls in some other imports that are Windows only?

that's what it looks like... even though there're no explicit build tags present. welp

@anmaxvl anmaxvl force-pushed the lcow-shm-size-runhcs-option branch 2 times, most recently from f2f7597 to ddbe1f5 Compare October 6, 2021 17:06
Copy link
Copy Markdown
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be good to see if we can screw with build tags enough or fix some things so we can import /internal/oci in /internal/guest but lgtm

@anmaxvl
Copy link
Copy Markdown
Contributor Author

anmaxvl commented Oct 6, 2021

Be good to see if we can screw with build tags enough or fix some things so we can import /internal/oci in /internal/guest but lgtm

I thought about doing some refactor and potentially export the annotations somewhere. I think we use hardcoded annotations in CRI/containerd forks/upstream as well.

@katiewasnothere
Copy link
Copy Markdown

I'm fine with moving the annotations to their own package if that helps here

@anmaxvl
Copy link
Copy Markdown
Contributor Author

anmaxvl commented Oct 19, 2021

I'm fine with moving the annotations to their own package if that helps here

opened a separate PR to address this #1201

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl force-pushed the lcow-shm-size-runhcs-option branch from ddbe1f5 to e213601 Compare October 19, 2021 23:55
Add new const annotation AnnotationLCOWDevShmSizeInKb for setting the
default size for /dev/shm in LCOW scenarios. Replace existing hardcoded
references with the new const. Overwrite container spec whenever the
annotation is present.

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl force-pushed the lcow-shm-size-runhcs-option branch from e213601 to 8020178 Compare October 19, 2021 23:59
@katiewasnothere
Copy link
Copy Markdown

Why do we want this in the runhcs options?

@anmaxvl
Copy link
Copy Markdown
Contributor Author

anmaxvl commented Oct 21, 2021

Why do we want this in the runhcs options?

This is a shortcut to enable workloads for one of our customers. The annotations approach is taking too much time to plumb through the entirety of our stack.

@anmaxvl
Copy link
Copy Markdown
Contributor Author

anmaxvl commented Oct 28, 2021

closing in favor of #1210

@anmaxvl anmaxvl closed this Oct 28, 2021
@anmaxvl anmaxvl deleted the lcow-shm-size-runhcs-option branch March 1, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants