Add LCOW /dev/shm size runhcs option#1190
Conversation
|
Well this is sad, it seems to be crying because you're using the oci package in the guest and it pulls in some other imports that are Windows only? |
that's what it looks like... even though there're no explicit build tags present. welp |
f2f7597 to
ddbe1f5
Compare
dcantah
left a comment
There was a problem hiding this comment.
Be good to see if we can screw with build tags enough or fix some things so we can import /internal/oci in /internal/guest but lgtm
I thought about doing some refactor and potentially export the annotations somewhere. I think we use hardcoded annotations in CRI/containerd forks/upstream as well. |
|
I'm fine with moving the annotations to their own package if that helps here |
opened a separate PR to address this #1201 |
Signed-off-by: Maksim An <maksiman@microsoft.com>
ddbe1f5 to
e213601
Compare
Add new const annotation AnnotationLCOWDevShmSizeInKb for setting the default size for /dev/shm in LCOW scenarios. Replace existing hardcoded references with the new const. Overwrite container spec whenever the annotation is present. Signed-off-by: Maksim An <maksiman@microsoft.com>
e213601 to
8020178
Compare
|
Why do we want this in the runhcs options? |
This is a shortcut to enable workloads for one of our customers. The annotations approach is taking too much time to plumb through the entirety of our stack. |
|
closing in favor of #1210 |
Add new const annotation AnnotationLCOWDevShmSizeInKb for setting the
default size for /dev/shm in LCOW scenarios. Replace existing hardcoded
references with the new const. Overwrite container spec whenever the
annotation is present.
Depends on #1201