Separate volume tests#1198
Closed
ambarve wants to merge 2 commits intomicrosoft:mainfrom
Closed
Conversation
Contributor
Author
|
Marked as draft to make sure this is not merged before kevpar/containerd#27, kevpar/cri#6 and #1188 is merged. |
Contributor
Author
|
Marked as draft temporarily as I am planning to rebase this on master and add one more test. |
Signed-off-by: Amit Barve <ambarve@microsoft.com>
Signed-off-by: Amit Barve <ambarve@microsoft.com>
ambarve
force-pushed
the
separate_volume_tests
branch
from
ead4ae7 to
99785ed
Compare
Contributor
Author
|
We might remove the support for overriding the scratch directory location. In that case the tests that this PR adds won't be applicable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for changes added in kevpar/containerd#27