Skip to content

[release/0.8] Support specifying a specific logrus log level for shim log output#1213

Merged
dcantah merged 1 commit intomicrosoft:release/0.8from
dcantah:cp-shim-log-level
Nov 1, 2021
Merged

[release/0.8] Support specifying a specific logrus log level for shim log output#1213
dcantah merged 1 commit intomicrosoft:release/0.8from
dcantah:cp-shim-log-level

Conversation

@dcantah
Copy link
Copy Markdown
Contributor

@dcantah dcantah commented Nov 1, 2021

Sometimes debug is a bit too noisy and can cause log rotation at a higher than
ideal rate.

This will be accompanied by an audit of our use of log levels throughout to make sure
they actually fit what level they're under.

Signed-off-by: Daniel Canter dcanter@microsoft.com
(cherry picked from commit a2d897c)

Signed-off-by: Daniel Canter dcanter@microsoft.com

Sometimes debug is a bit too noisy and can cause log rotation at a higher than
ideal rate.

This will be accompanied by an audit of our use of log levels throughout to make sure
they actually fit what level they're under.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
(cherry picked from commit a2d897c)
Signed-off-by: Daniel Canter <dcanter@microsoft.com>
@dcantah dcantah requested a review from a team as a code owner November 1, 2021 21:12
@dcantah dcantah changed the title Support specifying a specific logrus log level for shim log output [release/0.8] Support specifying a specific logrus log level for shim log output Nov 1, 2021
@dcantah
Copy link
Copy Markdown
Contributor Author

dcantah commented Nov 1, 2021

Realized this was never pulled into the release/0.8 branches. Would be nice to have for a new ctrd 1.5 release, and helps with the merge conflicts from just trying to cherry-pick #1197

Copy link
Copy Markdown
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcantah dcantah merged commit 6fcadb8 into microsoft:release/0.8 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants