[release/0.8] go.mod: Bump ttrpc to 1.1.0#1224
Conversation
This tag contains a fix for a deadlock we'd observed on Windows when multiple requests were made in parallel. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
|
Seems like a lot of dep changes. Was this just from running |
|
@kevpar Agreed.. but yes those were the steps. |
|
Why wasn't the other PR this long? |
|
Lines 147 to 177 in d726877 Looks like google.golang.org/protobuf wasn't used somehow on release/0.8. They're already there on master https://github.com/microsoft/hcsshim/blob/master/vendor/modules.txt#L218-L248. That's the majority of the new additions. |
|
@dcantah maybe do a separate PR for that change then so that this PR can stay relatively the same as the one to the main branch? |
|
Edit: Nvm I have so many tabs open I've got things backwards, the above is incorrect. Still looking into why this is Edit 2: They were originally vendored from a containerd 1.5 dependency bump in this repo, was just a beta however. So there's nothing I can really do to keep this more in line with the PR against master, it's just that master already has things present in /vendor that are used here because the containerd dep is 1.5.x. |
This tag contains a fix for a deadlock we'd observed on Windows when multiple
requests were made in parallel. containerd/ttrpc#94