Increase timeout for TestPseudoConsolePowershell#1253
Increase timeout for TestPseudoConsolePowershell#1253dcantah wants to merge 1 commit intomicrosoft:masterfrom
Conversation
On the CI machines I'd seen an instance of this hitting the timeout. The timeout in place may have been too optimistic so this change ups the timeout to receive the output to 10 seconds from 5. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
|
It takes ~10 seconds for the conpty to forward the output, or is part of the delay the powershell's startup? |
|
@helsaawy powershell startup is what I'm thinking. Let me check on my machine at least when the first output is received on average |
| @@ -207,14 +207,14 @@ func TestPseudoConsolePowershell(t *testing.T) { | |||
| }() | |||
|
|
|||
| cmd := "echo \"howdy from conpty\"\r\n" | |||
There was a problem hiding this comment.
Small nit, can we make "howdy from conpty" a const and use that on line 201 and format it into this string?
|
If its startup and we really care about timing, we may want to add a wait (with a timeout) earlier to check for proper init first, then use a smaller timeout for the forwarding. |
|
Oh actually, the reason for the failure might be due to a read containing only part of the string we're looking for. Gonna close this and come up with a better route |
3 participants
On the CI machines I'd seen an instance of this hitting the timeout. The
timeout in place may have been too optimistic so this change ups the
timeout to receive the output to 10 seconds from 5.
Signed-off-by: Daniel Canter dcanter@microsoft.com