Skip to content

[release/0.9] Ignore ERROR_ACCESS_DENIED on Kill (#1252)#1262

Merged
dcantah merged 1 commit intomicrosoft:release/0.9from
dcantah:ignore-access-denied
Jan 4, 2022
Merged

[release/0.9] Ignore ERROR_ACCESS_DENIED on Kill (#1252)#1262
dcantah merged 1 commit intomicrosoft:release/0.9from
dcantah:ignore-access-denied

Conversation

@dcantah
Copy link
Copy Markdown
Contributor

@dcantah dcantah commented Jan 4, 2022

When calling HcsTerminateProcess on a process that has exited, but we
still have open handles to, an ERROR_ACCESS_DENIED may be returned.

https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-terminateprocess#remarks

Signed-off-by: Gabriel Adrian Samfira gsamfira@cloudbasesolutions.com
(cherry picked from commit 58caeed)
Signed-off-by: Daniel Canter dcanter@microsoft.com

When calling HcsTerminateProcess on a process that has exited, but we
still have open handles to, an ERROR_ACCESS_DENIED may be returned.

https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-terminateprocess#remarks

Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
(cherry picked from commit 58caeed)
Signed-off-by: Daniel Canter <dcanter@microsoft.com>
@dcantah dcantah requested a review from a team as a code owner January 4, 2022 02:25
@dcantah
Copy link
Copy Markdown
Contributor Author

dcantah commented Jan 4, 2022

Assigning y'all as you'd looked at the change to master @anmaxvl @helsaawy. Reason for the backport is that containerd 1.6 will be on the 0.9.x line for hcsshim

@helsaawy
Copy link
Copy Markdown
Contributor

helsaawy commented Jan 4, 2022

lgtm

@dcantah dcantah merged commit a6b230d into microsoft:release/0.9 Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants