[release/0.9] Make kill noop on second run#1275
Merged
dcantah merged 1 commit intomicrosoft:release/0.9from Jan 11, 2022
Merged
[release/0.9] Make kill noop on second run#1275dcantah merged 1 commit intomicrosoft:release/0.9from
dcantah merged 1 commit intomicrosoft:release/0.9from
Conversation
If a kill has already been delivered, ignore subsequent calls to Kill() and simply return the previous status. This change also defines ErrProcessAlreadyStopped and ignores that error if encountered during kill. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com> (cherry picked from commit a8605ec) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
anmaxvl
approved these changes
Jan 11, 2022
katiewasnothere
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a kill has already been delivered, ignore subsequent calls to
Kill() and simply return the previous status.
This change also defines ErrProcessAlreadyStopped and ignores that
error if encountered during kill.
Signed-off-by: Gabriel Adrian Samfira gsamfira@cloudbasesolutions.com
(cherry picked from commit a8605ec)
Signed-off-by: Daniel Canter dcanter@microsoft.com
This is one of the fixes intended to help get the TestRestartMonitor test operational for Windows in upstream containerd