Skip to content

race condition with exitCh in (*UtilityVM).Start() #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helsaawy merged 1 commit into from
Nov 14, 2022
Merged

race condition with exitCh in (*UtilityVM).Start() #1562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/uvm/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ func (uvm *UtilityVM) Start(ctx context.Context) (err error) {
}()
defer cancel()

// create exitCh ahead of time to prevent race conditions between writing
// initalizing the channel and waiting on it during acceptAndClose
uvm.exitCh = make(chan struct{})

// Prepare to provide entropy to the init process in the background. This
// must be done in a goroutine since, when using the internal bridge, the
// call to Start() will block until the GCS launches, and this cannot occur
Expand Down Expand Up @@ -208,7 +212,6 @@ func (uvm *UtilityVM) Start(ctx context.Context) (err error) {
}()

// Start waiting on the utility VM.
uvm.exitCh = make(chan struct{})
go func() {
err := uvm.hcsSystem.Wait()
if err == nil {
Expand Down