Update golangci linter and clean go mod cache#1707
Merged
katiewasnothere merged 2 commits intomicrosoft:mainfrom Mar 23, 2023
Merged
Update golangci linter and clean go mod cache#1707katiewasnothere merged 2 commits intomicrosoft:mainfrom
katiewasnothere merged 2 commits intomicrosoft:mainfrom
Conversation
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Remove `//nolint` directives for varcheck, deadcode, and structcheck; they were deprecated in golangci-lint v1.49. Removed `//nolint` directives for `unused`; it appears a new version of that linter is less false-positive prone. Fix instance of loop variable being captured in closure for `Test_RunPodSandbox_Concurrently` in `policy_test.go`. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Mar 23, 2023
helsaawy
approved these changes
Mar 23, 2023
Contributor
helsaawy
left a comment
helsaawy
left a comment
There was a problem hiding this comment.
not sure i should be allowed to approve, but 🤷
Author
|
Lol thanks for fixing the errors @helsaawy, merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix a problem seen in #1704. In that PR, it appears that the linter continuously fails with
However, in that PR that package has been removed and all references to it in the repo have been updated.
We believe this is an issue with the linter's mod cache being out of date. This PR aims to address that by updating the linter version and adding an additional step beforehand to clean the mod cache.