Add code to format disk as ext4 in guest#1717
Merged
katiewasnothere merged 1 commit intomicrosoft:mainfrom Apr 19, 2023
Merged
Conversation
kevpar
reviewed
Apr 6, 2023
katiewasnothere
force-pushed
the
kabaldau/add_back_ext4_formatting
branch
from
754ff7b to
06fc6cc
Compare
kevpar
reviewed
Apr 11, 2023
kevpar
reviewed
Apr 11, 2023
Member
|
PR/commit description are outdated. |
katiewasnothere
force-pushed
the
kabaldau/add_back_ext4_formatting
branch
from
06fc6cc to
c89b56c
Compare
katiewasnothere
changed the title
katiewasnothere
changed the title
katiewasnothere
force-pushed
the
kabaldau/add_back_ext4_formatting
branch
from
c89b56c to
696699d
Compare
Author
|
Updated to fix comment, move to use fmt.Errorf instead of "errors" package, and updated PR description and title. |
Author
|
Test failures are unrelated |
msscotb
requested changes
Apr 14, 2023
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
kabaldau/add_back_ext4_formatting
branch
from
696699d to
daa723f
Compare
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…ack_ext4_formatting Add code to format disk as ext4 in guest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new call to format a disk as ext4 in the guest.
This PR does NOT hook up the code flow, that will come in later PRs.