[test]Resolve containerd dependency conflicts#1860
Closed
helsaawy wants to merge 1 commit intomicrosoft:mainfrom
Closed
[test]Resolve containerd dependency conflicts#1860helsaawy wants to merge 1 commit intomicrosoft:mainfrom
helsaawy wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Upgrading to `containerd` 1.7.3 causes linter/build issues for the gcs tests because of dependency conflict. The `test/` modules freezes `k8s.io/cri-api` at `v0.25`, since the `v1alpha2` API is removed in `v0.26`. However, `containerd` 1.7.2 upgrades `k8s.io/cri-api` to `v0.27` from `v0.26`, which adds new fields that `containerd/pkg/cri` relies on for its Linux code paths. This causes the gcs tests, which uses `github.com/containerd/containerd/pkg/cri/opts` (and other pkgs) to fail, since the new containerd code cannot find the required fields in `k8s.io/cri-api`. Therefore freeze `containerd` to `v1.7.0` until `test/cri-container` no longer needs to freeze `k8s.io/cri-api`. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Contributor
Author
|
Superseded by #1958 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading to
containerd1.7.3 causes linter/build issues for the gcs tests because of dependency conflict.The
test/modules freezesk8s.io/cri-apiatv0.25, since thev1alpha2API is removed inv0.26.However,
containerd1.7.2 upgradesk8s.io/cri-apitov0.27fromv0.26, which adds new fields thatcontainerd/pkg/crirelies on for its Linux code paths.This causes the gcs tests, which uses
github.com/containerd/containerd/pkg/cri/opts(and other pkgs) to fail, since the new containerd code cannot find the required fields ink8s.io/cri-api.Therefore freeze
containerdtov1.7.0untiltest/cri-containerno longer needs to freezek8s.io/cri-api.