Revert "Use kmod library to load modules"#2091
Merged
katiewasnothere merged 1 commit intomicrosoft:mainfrom Apr 1, 2024
Merged
Revert "Use kmod library to load modules"#2091katiewasnothere merged 1 commit intomicrosoft:mainfrom
katiewasnothere merged 1 commit intomicrosoft:mainfrom
Conversation
This reverts commit 8c5f531. Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
kabaldau/revert_init_kmod
branch
from
32690fa to
d736453
Compare
anmaxvl
approved these changes
Mar 30, 2024
helsaawy
approved these changes
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8c5f531.
The changes introduced in #2034, changed the init binary from using statically loaded dependencies to dynamic dependencies. This can be an issue since some builds of libkmod (such as the one for Ubuntu 22.04) use the optional dependencies for libkmod (mentioned here), lzma and zstd. Some UVM images do not have these libraries installed by default.
Reverting the change that brings in libkmod while we work on installing libkmod without the optional dependencies.