Add support for loading modules in init script when makefile variable is set#2167
Merged
katiewasnothere merged 1 commit intomicrosoft:mainfrom Jun 23, 2024
Merged
Conversation
is set. Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
helsaawy
approved these changes
Jun 13, 2024
msscotb
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds back the support for loading kernel modules in the init script and adds a definition block around the code. This was necessary because some images we use do not have all the dependencies that kmod needs installed, causing the pods to fail to boot. To compile with this variable, you can run:
This PR is essentially this PR #2034 with the additional Makefile work and C macro.