Skip to content

C-WCOW: SecurityPolicy and sidecar fixes#2527

Merged
anmaxvl merged 3 commits intomicrosoft:mainfrom
MahatiC:securitypolicy-review
Nov 20, 2025
Merged

C-WCOW: SecurityPolicy and sidecar fixes#2527
anmaxvl merged 3 commits intomicrosoft:mainfrom
MahatiC:securitypolicy-review

Conversation

@MahatiC
Copy link
Copy Markdown
Member

@MahatiC MahatiC commented Sep 25, 2025 •
edited
Loading

  • This addresses some of the review comments from the original pull request and a command line fix related to SecurityPolicy.

@MahatiC
C-WCOW: Use go channel
fa9158d 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC
C-WCOW: Move security context dir code
f4d6807 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC MahatiC force-pushed the securitypolicy-review branch from 0e7cadb to 95ea954 Compare September 25, 2025 12:39
@MahatiC MahatiC marked this pull request as ready for review September 25, 2025 17:22
@MahatiC MahatiC requested a review from a team as a code owner September 25, 2025 17:22
@MahatiC
Copy link
Copy Markdown
Member Author

MahatiC commented Oct 16, 2025

@ambarve @rawahars Could you have a look at this?

@MahatiC MahatiC requested a review from anmaxvl October 31, 2025 11:52
@MahatiC
Copy link
Copy Markdown
Member Author

MahatiC commented Nov 6, 2025

@msscotb Can this get a reviewer assigned please?

@anmaxvl anmaxvl self-assigned this Nov 12, 2025
anmaxvl
anmaxvl reviewed Nov 12, 2025
View reviewed changes
Comment thread internal/gcs-sidecar/handlers.go
@MahatiC
C-WCOW: Differentiate container cmdline
d7e2efe 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC MahatiC force-pushed the securitypolicy-review branch from 95ea954 to d7e2efe Compare November 12, 2025 16:24
@MahatiC MahatiC requested a review from anmaxvl November 13, 2025 09:34
@KenGordon KenGordon self-requested a review November 20, 2025 18:13
KenGordon
KenGordon approved these changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@KenGordon KenGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as I expected, so good to go.

@anmaxvl anmaxvl merged commit a19edd0 into microsoft:main Nov 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmaxvl anmaxvl anmaxvl approved these changes

+1 more reviewer

@KenGordon KenGordon KenGordon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmaxvl anmaxvl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MahatiC @anmaxvl @KenGordon