vsmb share redirector start and bind to vmbus#2560
Merged
pomahade merged 1 commit intomicrosoft:mainfrom Nov 25, 2025
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
07066a4 to
35ee620
Compare
helsaawy
requested changes
Nov 13, 2025
Contributor
helsaawy
left a comment
There was a problem hiding this comment.
Is there any way we can add testing for the code in internal/gcs-sidecar/vsmb.go?
Theres a lot of error-prone looking Win32 interactions
Contributor
Author
|
Signed-off-by: Pooja Mahadev Soundalgekar <pomahade@microsoft.com>
helsaawy
approved these changes
Nov 24, 2025
anmaxvl
approved these changes
Nov 24, 2025
| startReq.Reserved1 = 0 | ||
| startReq.InstanceConfig = SMB2InstanceConfiguration{} | ||
| startReq.DefaultConnectionProperties = LMRConnectionProperties{} | ||
| startReq.DefaultConnectionProperties.Flags1 = 0x1F |
Contributor
There was a problem hiding this comment.
you could also initialize it inline, e.g.
we can cleanup later though.
startReq := LMRStartInstanceRequest {
DefaultConnectionProperties: LMRConnectionProperties {
Flags1 = 0x1f
...
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vsmb.go code is called for main.go, it starts the lanmanworkstation service, creates redirector instance and binds it to the vmbus. We can then use shimdiag share to share between host and guest.