Add LCOW assigned device logs; increase timeout#2589
Merged
helsaawy merged 1 commit intomicrosoft:mainfrom Jan 16, 2026
Merged
Conversation
Drop logs when iterating over host devices from info to trace. Add more logs (and span) to `AddAssignedDevice` function for tracing where time is spent when assigning devices. Increase `AddAssignedDevice` timeout from 10 seconds to 60 to allow more time when adding a large number of devices or waiting on host to make them available. Add log when adding OCI runtime hook for nvidia tool. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Jan 16, 2026
jiechen0826
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop logs when iterating over host devices from info to trace.
Add more logs (and span) to
AddAssignedDevicefunction for tracing where time is spent when assigning devices.Increase
AddAssignedDevicetimeout from 10 seconds to 60 to allow more time when adding a large number of devices or waiting on host to make them available.Add log when adding OCI runtime hook for nvidia tool.