Adding functions to modify network settings and policies. Adding RemoteSubnetRoutePolicy.#358
Conversation
| network.AddPolicy(*remoteSubnetRoutePolicy) | ||
|
|
||
| //Reload the network object from HNS. | ||
| network, err = GetNetworkByID(network.Id) |
There was a problem hiding this comment.
I'm not fond of this pattern. We shouldn't have to reload the network after modifying. After updating the network (or endpoint) the network should be automatically updated. However, this behavior is consistent with the Endpoint API's.
I'd prefer we change this behavior in a separate PR.
|
@madhanrm - Want to give a quick review? |
|
@jterry75 I've emailed the team about the PR. At some point in time I'll learn there GitHub aliases and add them to the PR. |
| return loadBalancer.Create() | ||
| } | ||
|
|
||
| func HcnCreateRemoteSubnetRoute() (*PolicyNetworkRequest, error) { |
There was a problem hiding this comment.
nit: Can you rename this to HcnCreateTestRemoteSubnetRoute
|
@madhanrm - Let me know when this LGT you and I'll merge. This is really your code |
|
Forgot to rerun the tests after all the changes. |
|
LGTM |
|
Validated all the tests run. |
|
@erfrimod: FYI |
|
This test would run only on RS5+ |
Remove v2 dependency on v1 for host processes
4 participants
No description provided.