Skip to content

Skip uart enumeration on production boot #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jterry75 merged 1 commit into from
Nov 28, 2018
Merged

Skip uart enumeration on production boot #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/uvm/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,11 @@ func Create(opts *UVMOptions) (_ *UtilityVM, err error) {
vm.Devices.VideoMonitor = &hcsschema.VideoMonitor{}
}

if !vmDebugging {
if vmDebugging {
Copy link
Copy Markdown
Member

@jstarks jstarks Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you only need to do this when a COM port is enabled above. So you could move this into the existing if block.

Copy link
Copy Markdown
Member

@jstarks jstarks Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jterry75 did you see this?

Copy link
Copy Markdown
Contributor Author

@jterry75 jterry75 Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I am submitting another change to move it.

Copy link
Copy Markdown
Contributor Author

@jterry75 jterry75 Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#398

kernelArgs += " 8250_core.nr_uarts=1 8250_core.skip_txen_test=1"
} else {
// Terminate the VM if there is a kernel panic.
kernelArgs += " panic=-1"
kernelArgs += " panic=-1 8250_core.nr_uarts=0"
}

if opts.KernelBootOptions != "" {
Expand Down