Add a separate go.mod for test/ directory to avoid dependency creep in root go.mod#789
Conversation
…n root go.mod Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
changed the title
dims
force-pushed
the
add-new-go.mod-in-test-directory-to-cleanup-root-dependencies
branch
3 times, most recently
from
95efc9d to
d2ed04b
Compare
dims
changed the title
|
@dcantah what do you think? |
|
@dims We've had talks of just splitting the cri-containerd tests off of this repo entirely which might be the better option at this point. This looks fine but I'll consult with the team and try and get back to you on Monday :) |
|
@dcantah sounds like a plan! please also cut a tag/release for kubernetes 1.19 as well once either of the options land. Given previous releases code freeze for 1.19 would be somewhere middle to end of May and the 1.19 release middle to end of June. we'd need a lot of soak time well before the deadlines to make sure we didn't break anything. |
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
This looks fine to me and seems like a good solution. Just confused on one thing which I've commented.
dims
force-pushed
the
add-new-go.mod-in-test-directory-to-cleanup-root-dependencies
branch
from
d2ed04b to
4def607
Compare
|
@dims it seems the ci failed |
dims
force-pushed
the
add-new-go.mod-in-test-directory-to-cleanup-root-dependencies
branch
2 times, most recently
from
e184f44 to
1b2059d
Compare
|
@dcantah this is green now. PTAL |
|
@dims one tiny little thing left. It seems now that we cd into the test dir to build the executables where the test artifacts are residing is now the test folder so the ci cant find them. Can you update the appveyor.yml to reflect these new paths for the test executables? So instead of 'runhcs.test.exe' -> './test/runhcs.test.exe' and so on for the other 3 |
- run the schema version test Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
add-new-go.mod-in-test-directory-to-cleanup-root-dependencies
branch
from
1b2059d to
139da32
Compare
|
LGTM |
In microsoft/hcsshim#789, hcsshim removed its dependency on k8s.io/kubernetes. 5 imports upstream, we need to `replace` it in order to not pull in k8s.io/kubernetes. Rather than that, would be ideal for oras to just update.
In microsoft/hcsshim#789, hcsshim removed its dependency on k8s.io/kubernetes. 5 imports upstream, we need to `replace` it in order to not pull in k8s.io/kubernetes. Rather than that, would be ideal for oras to just update.
2 participants
Trying to cleanup dependencies of hcsshim (when used as a library) in kubernetes.
Signed-off-by: Davanum Srinivas davanum@gmail.com