Skip to content

Add support for creating late clones via hcsshim#840

Merged
ambarve merged 1 commit intouser/ambarve/lcpr3_networking_changesfrom
user/ambarve/lcpr4_clone_contianer
Jan 27, 2021
Merged

Add support for creating late clones via hcsshim#840
ambarve merged 1 commit intouser/ambarve/lcpr3_networking_changesfrom
user/ambarve/lcpr4_clone_contianer

Conversation

@ambarve
Copy link
Copy Markdown
Contributor

@ambarve ambarve commented Jun 13, 2020

This is one of the many small PRs that enable the support for late cloning.
This commit adds the set of functions that expose the late cloning functionality
from hcsshim and adds new annotations for clients to use the late cloning feature.

Signed-off-by: Amit Barve ambarve@microsoft.com

@ambarve ambarve changed the title Add support for creating late clones via hcsshim [Late_clone PR 4/5] Add support for creating late clones via hcsshim Jun 13, 2020
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch 2 times, most recently from d882b1f to b30b021 Compare June 15, 2020 20:41
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from f3c05e0 to 0602db5 Compare June 16, 2020 00:47
@ambarve ambarve marked this pull request as ready for review June 16, 2020 05:40
@ambarve ambarve requested a review from a team as a code owner June 16, 2020 05:40
@ambarve ambarve mentioned this pull request Jun 17, 2020
Closed
@ambarve ambarve changed the title [Late_clone PR 4/5] Add support for creating late clones via hcsshim Add support for creating late clones via hcsshim Jun 17, 2020
@kevpar
Copy link
Copy Markdown
Member

kevpar commented Jul 15, 2020

Please rebase these commits into a more curated set for review and check-in.

dcantah
dcantah reviewed Aug 11, 2020
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/pod.go Outdated
dcantah
dcantah reviewed Aug 11, 2020
View reviewed changes
Comment thread internal/clone/registry.go Outdated
dcantah
dcantah reviewed Aug 11, 2020
View reviewed changes
Comment thread internal/clone/registry.go Outdated
dcantah
dcantah reviewed Aug 11, 2020
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/exec_hcs.go Outdated
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 14f71f8 to 9fb2388 Compare August 18, 2020 22:29
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from 3f1bc7a to c7e0f63 Compare August 18, 2020 22:29
kevpar
kevpar reviewed Sep 1, 2020
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/pod.go Outdated
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 9fb2388 to 3932868 Compare September 17, 2020 05:56
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch 2 times, most recently from 7a15559 to 014132d Compare September 18, 2020 21:01
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 3932868 to 258739d Compare September 18, 2020 22:17
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from 014132d to 6dabd0d Compare September 18, 2020 22:22
katiewasnothere
katiewasnothere reviewed Sep 23, 2020
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/clone.go Outdated
katiewasnothere
katiewasnothere reviewed Sep 23, 2020
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/task_hcs.go Outdated
katiewasnothere
katiewasnothere reviewed Sep 23, 2020
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/exec_clone.go
katiewasnothere
katiewasnothere reviewed Sep 23, 2020
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/task_hcs.go Outdated
katiewasnothere
katiewasnothere reviewed Sep 23, 2020
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/task_hcs.go Outdated
katiewasnothere
katiewasnothere reviewed Sep 23, 2020
View reviewed changes
Comment thread internal/clone/registry.go
kevpar
kevpar reviewed Sep 29, 2020
View reviewed changes
Comment thread internal/clone/registry.go Outdated
kevpar
kevpar reviewed Sep 29, 2020
View reviewed changes
Comment thread internal/clone/registry.go Outdated
kevpar
kevpar reviewed Sep 29, 2020
View reviewed changes
Comment thread internal/clone/registry.go Outdated
kevpar
kevpar reviewed Sep 29, 2020
View reviewed changes
Comment thread internal/clone/registry.go Outdated
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from 6dabd0d to a7848c5 Compare October 12, 2020 19:41
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from a7848c5 to b741e39 Compare October 22, 2020 05:07
@ambarve ambarve mentioned this pull request Oct 22, 2020
Merged
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from b741e39 to 8625f9a Compare October 22, 2020 05:56
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 258739d to fff6c8f Compare October 22, 2020 05:57
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from 8625f9a to a0596a7 Compare October 22, 2020 06:07
@ambarve ambarve mentioned this pull request Nov 13, 2020
Closed
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from fff6c8f to 72da34c Compare November 16, 2020 20:36
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from a0596a7 to ff2fbe3 Compare November 16, 2020 20:36
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from ff2fbe3 to 3fe9813 Compare December 10, 2020 18:56
@kevpar
Copy link
Copy Markdown
Member

kevpar commented Dec 15, 2020

One thing to consider is how templates will show up in queries for pods/containers, as well as how they will handle being queried for inspect info and stats. We should make sure reasonable results are returned, and that it doesn't error out.

kevpar
kevpar reviewed Dec 15, 2020
View reviewed changes
Comment thread internal/uvm/clone.go
kevpar
kevpar reviewed Dec 15, 2020
View reviewed changes
Comment thread internal/clone/registry.go
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 72da34c to e6b428b Compare December 22, 2020 09:37
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from 3fe9813 to 2379dd1 Compare December 22, 2020 09:38
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from e6b428b to e91e7f2 Compare December 23, 2020 22:08
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from 2379dd1 to 65faf47 Compare December 23, 2020 22:09
kevpar
kevpar reviewed Jan 20, 2021
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/clone.go Outdated
kevpar
kevpar reviewed Jan 20, 2021
View reviewed changes
Comment thread internal/cow/cow.go
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from ab25514 to 5461a16 Compare January 21, 2021 07:05
kevpar
kevpar reviewed Jan 21, 2021
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/task_hcs.go
kevpar
kevpar reviewed Jan 22, 2021
View reviewed changes
Comment thread internal/hcsoci/create.go
kevpar
kevpar reviewed Jan 22, 2021
View reviewed changes
Comment thread cmd/containerd-shim-runhcs-v1/task_hcs.go
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from 5461a16 to 9de34df Compare January 27, 2021 18:40
kevpar
kevpar approved these changes Jan 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ambarve
Add support for creating late clones via hcsshim
452b379 
This is one of the many small PRs that enable the support for late
cloning.This commit adds the set of functions that expose the late cloning
functionality from hcsshim and adds new annotations for clients to use
the late cloning feature.

Signed-off-by: Amit Barve <ambarve@microsoft.com>
@ambarve ambarve force-pushed the user/ambarve/lcpr4_clone_contianer branch from 9de34df to 452b379 Compare January 27, 2021 22:20
@ambarve ambarve merged commit 2c3c8d4 into user/ambarve/lcpr3_networking_changes Jan 27, 2021
@dcantah dcantah mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevpar kevpar kevpar approved these changes

+2 more reviewers

@katiewasnothere katiewasnothere katiewasnothere left review comments

@dcantah dcantah dcantah left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambarve @kevpar @katiewasnothere @dcantah