Skip to content

AppVeyor: test with Go 1.15.2#844

Closed
thaJeztah wants to merge 1 commit intomicrosoft:masterfrom
thaJeztah:bump_go_1.15
Closed

AppVeyor: test with Go 1.15.2#844
thaJeztah wants to merge 1 commit intomicrosoft:masterfrom
thaJeztah:bump_go_1.15

Conversation

@thaJeztah
Copy link
Copy Markdown
Contributor

@thaJeztah thaJeztah commented Jun 24, 2020

I noticed that this failed to compile on the containerd repository (containerd/containerd#4050 (comment));

HEAD is now at 5bc557d Added Version support for IPv6 Dual stack support in HNS
+ GO111MODULE=on
+ go build -mod=vendor -o /d/a/containerd/containerd/src/github.com/containerd/containerd/containerd-shim-runhcs-v1.exe ./cmd/containerd-shim-runhcs-v1
# github.com/Microsoft/hcsshim/cmd/containerd-shim-runhcs-v1
panic: runtime error: slice bounds out of range [128:0]

goroutine 1 [running]:
cmd/link/internal/ld.addpersrc(0xc00008d500)
	c:/go/src/cmd/link/internal/ld/pe.go:1490 +0x33d
cmd/link/internal/ld.Asmbpe(0xc00008d500)
	c:/go/src/cmd/link/internal/ld/pe.go:1568 +0x253
cmd/link/internal/amd64.asmb2(0xc00008d500)
	c:/go/src/cmd/link/internal/amd64/asm.go:842 +0xfa
cmd/link/internal/ld.Main(0x135f860, 0x20, 0x20, 0x1, 0x7, 0x10, 0x0, 0x0, 0x11bf875, 0x1b, ...)
	c:/go/src/cmd/link/internal/ld/main.go:349 +0x1509
main.main()
	c:/go/src/cmd/link/main.go:68 +0x1fc
##[error]Process completed with exit code 2.

Opening a draft PR here to see if the problem reproduces in this repository (and if it's a bug in this code, or if there's a bug in Golang)

/cc @kevpar @jterry75

@thaJeztah thaJeztah changed the title AppVeyor: test with Go 1.15beta1 [draft] AppVeyor: test with Go 1.15beta1 Jun 24, 2020
@thaJeztah thaJeztah changed the title [draft] AppVeyor: test with Go 1.15beta1 [draft] AppVeyor: test with Go 1.15rc1 Jul 25, 2020
@thaJeztah
Copy link
Copy Markdown
Contributor Author

updated to 1.15rc1

@thaJeztah thaJeztah changed the title [draft] AppVeyor: test with Go 1.15rc1 [draft] AppVeyor: test with Go 1.15rc2 Aug 8, 2020
@thaJeztah
Copy link
Copy Markdown
Contributor Author

updated to v1.15rc2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title [draft] AppVeyor: test with Go 1.15rc2 [draft] AppVeyor: test with Go 1.15.2 Sep 29, 2020
@thaJeztah thaJeztah changed the title [draft] AppVeyor: test with Go 1.15.2 AppVeyor: test with Go 1.15.2 Sep 29, 2020
@thaJeztah thaJeztah marked this pull request as ready for review September 29, 2020 16:09
@thaJeztah thaJeztah requested a review from a team as a code owner September 29, 2020 16:09
@thaJeztah
Copy link
Copy Markdown
Contributor Author

Go 1.15 is GA now, so updated to Go 1.15.2, and moved out of draft

@thaJeztah
Copy link
Copy Markdown
Contributor Author

Obsoleted by #926, which also bumps Go to 1.15

@thaJeztah thaJeztah closed this Mar 2, 2021
@thaJeztah thaJeztah deleted the bump_go_1.15 branch March 2, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant