Skip to content

Fix stderr comment in containerd-shim serve command #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcantah merged 1 commit into from
Apr 8, 2021
Merged

Fix stderr comment in containerd-shim serve command #995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/containerd-shim-runhcs-v1/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ var serveCommand = cli.Command{
// new one. If serve is decided it execs this entry point `shim serve`.
// The handoff logic is that this shim will serve the ttrpc entrypoint
// with only stderr set by the caller. Once the shim has successfully
// served the entrypoint it is required to close stderr to alert the
// served the entrypoint it is required to close stdout to alert the
// caller it has completed to the point of handoff. If it fails it will
// write the error to stderr and the caller will forward the error on as
// part of the `shim start` failure path. Once successfully served the
Expand Down