Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

Conversation

@ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented Oct 31, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #909 (a37e810) into main (83df149) will increase coverage by 1.37%.
The diff coverage is 30.76%.

Impacted file tree graph

Flag Coverage Δ
hi-ml 83.30% <ø> (ø)
hi-ml-azure 27.28% <30.76%> (+0.14%) ⬆️
hi-ml-cpath 76.13% <ø> (+2.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hi-ml-azure/src/health_azure/utils.py 29.96% <33.33%> (+0.12%) ⬆️
hi-ml-azure/src/health_azure/himl.py 43.18% <30.00%> (+0.62%) ⬆️

... and 10 files with indirect coverage changes

@ant0nsc ant0nsc requested review from Shruthi42, dccastro and kenza-bouzid and removed request for kenza-bouzid November 3, 2023 18:35
Comment on lines +460 to +461
"Found environment variables for Service Principal authentication: First characters of App ID "
f"are {service_principal_id[:8]}... in tenant {tenant_id[:8]}..."

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (secret)](1) as clear text. This expression logs [sensitive data (secret)](2) as clear text.
Comment on lines +1942 to +1943
"Found environment variables for Service Principal authentication: First characters of App ID "
f"are {service_principal_id[:8]}... in tenant {tenant_id[:8]}..."

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (secret)](1) as clear text. This expression logs [sensitive data (secret)](2) as clear text.
@ant0nsc ant0nsc merged commit 2d8a380 into main Nov 8, 2023
@ant0nsc ant0nsc deleted the antonsc/command_in_config branch November 8, 2023 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants