Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

Conversation

@ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented Mar 19, 2024

At present, only ServicePrincipal and InteractiveAuthentication are supported for AzureML SDK v1. This PR adds AzureCLI as a third option. This sets the stage for password-free authentication in pipelines

Comment on lines +61 to +62
"Found environment variables for Service Principal authentication: First characters of App ID "
f"are {service_principal_id[:8]}... in tenant {tenant_id[:8]}..."

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (secret)](1) as clear text. This expression logs [sensitive data (secret)](2) as clear text.
Comment on lines +79 to +81
"Using interactive login to Azure. To use Service Principal authentication, set the environment "
f"variables {ENV_SERVICE_PRINCIPAL_ID}, {ENV_SERVICE_PRINCIPAL_PASSWORD}, and {ENV_TENANT_ID}. "
"For Azure CLI authentication, log in using 'az login' and ensure that the subscription is set."

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (password)](1) as clear text.
Comment on lines +181 to +182
"Found environment variables for Service Principal authentication: First characters of App ID "
f"are {service_principal_id[:8]}... in tenant {tenant_id[:8]}..."

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (secret)](1) as clear text. This expression logs [sensitive data (secret)](2) as clear text.
@codecov
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 42.16867% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 70.93%. Comparing base (aebaf3e) to head (d898687).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
hi-ml 83.33% <ø> (ø)
hi-ml-azure 27.39% <42.16%> (+0.25%) ⬆️
hi-ml-cpath 76.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hi-ml-azure/src/health_azure/utils.py 28.97% <100.00%> (-0.64%) ⬇️
hi-ml-azure/src/health_azure/auth.py 40.74% <40.74%> (ø)

@ant0nsc ant0nsc requested review from Shruthi42 and fepegar March 19, 2024 12:01
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ant0nsc! Nice to see utils getting smaller :)

@ant0nsc ant0nsc merged commit 97ea3be into main Mar 19, 2024
@ant0nsc ant0nsc deleted the antonsc/new_auth branch March 19, 2024 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants