This repository was archived by the owner on Nov 21, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
MNT: Update hi-ml-multimodal
#928
Merged
fepegar
merged 7 commits into
main
from
fperezgarcia/biovil-t-classifier-py310-compatible
Apr 11, 2024
Merged
MNT: Update hi-ml-multimodal
#928
fepegar
merged 7 commits into
main
from
fperezgarcia/biovil-t-classifier-py310-compatible
Apr 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shruthi42
reviewed
Apr 10, 2024
|
|
||
|
|
||
| def get_biovil_t_image_encoder() -> ImageModel: | ||
| def get_biovil_t_image_encoder(**kwargs) -> ImageModel: |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the need for **kwargs here?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so we can instantiate a classifier on top:
| self.classifier = self.create_downstream_classifier() if downstream_classifier_kwargs else None |
It was necessary for one of our applications.
Contributor
Author
|
I think the security warnings are related to cpath. |
Shruthi42
approved these changes
Apr 10, 2024
ant0nsc
approved these changes
Apr 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users (including ourselves) keep having issues installing
hi-ml-multimodal. I've unpinned the requirements so it's easy to install and use. I've had to update some bits that were using ancient versions of e.g. TorchVision. I've checked the notebook and it's working fine.Related issues:
Fixes #850.
Fixes #916.
Fixes #927.