Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

Conversation

@fepegar
Copy link
Contributor

@fepegar fepegar commented Apr 10, 2024

Users (including ourselves) keep having issues installing hi-ml-multimodal. I've unpinned the requirements so it's easy to install and use. I've had to update some bits that were using ancient versions of e.g. TorchVision. I've checked the notebook and it's working fine.

Related issues:

Fixes #850.
Fixes #916.
Fixes #927.

@fepegar fepegar changed the title Update hi-ml-multimodal MNT: Update hi-ml-multimodal Apr 10, 2024
@fepegar fepegar marked this pull request as ready for review April 10, 2024 16:45
@fepegar fepegar requested review from Shruthi42, ant0nsc and corcra April 10, 2024 16:45


def get_biovil_t_image_encoder() -> ImageModel:
def get_biovil_t_image_encoder(**kwargs) -> ImageModel:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the need for **kwargs here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so we can instantiate a classifier on top:

self.classifier = self.create_downstream_classifier() if downstream_classifier_kwargs else None

It was necessary for one of our applications.

@fepegar
Copy link
Contributor Author

fepegar commented Apr 10, 2024

I think the security warnings are related to cpath.

@fepegar fepegar merged commit 61a2c4d into main Apr 11, 2024
@fepegar fepegar deleted the fperezgarcia/biovil-t-classifier-py310-compatible branch April 11, 2024 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

4 participants