Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

Conversation

@fepegar
Copy link
Contributor

@fepegar fepegar commented May 13, 2024

When hyperparam_args is passed, the command is modified to add the argument in the settings. For example, if the looks like {learning_rate: [1, 2, 3]}, something like --learning_rate=${{inputs.learning_rate}} will be added to the command. But sometimes we wouldn't want the dashes, e.g., when using Hydra (learning_rate=${{inputs.learning_rate}} or maybe +learning_rate=${{inputs.learning_rate}}). This PR adds support to specify the prefix for the argument (default: "--"). For Hydra, we might want, e.g., "" or "+".

Copy link
Contributor

@vale-salvatelli vale-salvatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fepegar fepegar merged commit 664ac09 into main May 15, 2024
@fepegar fepegar deleted the fperezgarcia/support-custom-hyperdrive-arg-prefix branch May 15, 2024 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants