Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

Conversation

@fepegar
Copy link
Contributor

@fepegar fepegar commented May 31, 2024

Currently, the argument wait_for_completion_show_output is ignored for SDK v2 submissions. This PR adds support to propagate it so the job outputs are printed.

@fepegar fepegar requested a review from ant0nsc May 31, 2024 12:48
@fepegar fepegar changed the title Add support to show run outputs in SDK v2 ENH: Add support to show run outputs in SDK v2 May 31, 2024
@codecov
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.60%. Comparing base (f4e21b7) to head (62b4f1e).
Report is 8 commits behind head on main.

Files Patch % Lines
hi-ml-azure/src/health_azure/utils.py 9.09% 10 Missing ⚠️
hi-ml-azure/src/health_azure/himl.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
hi-ml-azure 26.10% <8.33%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hi-ml-azure/src/health_azure/himl.py 43.66% <0.00%> (+1.00%) ⬆️
hi-ml-azure/src/health_azure/utils.py 28.42% <9.09%> (-0.27%) ⬇️

... and 2 files with indirect coverage changes

@fepegar fepegar requested a review from samb-t August 23, 2024 08:21
@fepegar fepegar merged commit 598b78f into main Aug 23, 2024
@fepegar fepegar deleted the fperezgarcia/show-job-output branch August 23, 2024 17:01
@fepegar
Copy link
Contributor Author

fepegar commented Aug 23, 2024

Thank you both for reviewing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants