This repository was archived by the owner on Nov 21, 2025. It is now read-only.
ENH: Add support to pass parameters used for Singularity #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fepegar
changed the title
Contributor
Author
|
|
Collaborator
Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
samb-t
approved these changes
Apr 2, 2025
Contributor
samb-t
left a comment
samb-t
left a comment
There was a problem hiding this comment.
Approved. If we drop support for SDK v1 at some point, I would be in favour of simplifying this and just directly passing a JobResourceConfiguration object rather than flattening everything out. E.g. I can see a world where we want to pass a locations list as well.
Contributor
Author
|
Thank you both for reviewing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.