Skip to content

Comments

feat(instructions): add DT-aware task-reviewer review context#714

Open
kavithasreenath wants to merge 2 commits intomicrosoft:mainfrom
kavithasreenath:feat/593-dt-rpi-review-context
Open

feat(instructions): add DT-aware task-reviewer review context#714
kavithasreenath wants to merge 2 commits intomicrosoft:mainfrom
kavithasreenath:feat/593-dt-rpi-review-context

Conversation

@kavithasreenath
Copy link
Contributor

Pull Request

Description

Add dt-rpi-review-context.instructions.md, a DT-aware overlay for the task-reviewer role. When reviewing artifacts under .copilot-tracking/dt/, this instructions file shifts focus from code correctness to coaching quality, method fidelity, and stakeholder coverage.

Key components:

  • Review criteria reframing table mapping standard review concepts to DT-informed equivalents
  • Quality criteria per artifact type (coaching, method, deep, industry, handoff, agent, output, coaching state)
  • Review checklist additions for coaching tone, fidelity enforcement, stakeholder coverage, evidence grounding, iteration support, and token budgets
  • Anti-patterns table with severity ratings (7 patterns including 2 Critical)
  • Severity mapping table with definitions and examples

Complements co-loaded instruction files: dt-quality-constraints, dt-coaching-identity, dt-method-sequencing, dt-rpi-handoff-contract.

Related Issue(s)

Closes #593

Type of Change

AI Artifacts:

  • Reviewed contribution with prompt-builder agent and addressed all feedback
  • Copilot instructions (.github/instructions/*.instructions.md)

Sample Prompts (for AI Artifact Contributions)

User Request:

Review a DT coaching artifact in .copilot-tracking/dt/ using the task-reviewer workflow.

Execution Flow:

  1. Task-reviewer activates on files matching **/.copilot-tracking/dt/**
  2. Instructions auto-load and augment standard review behavior
  3. Reviewer applies DT Review Checklist Additions alongside standard checks
  4. Anti-patterns table flags DT-specific violations with severity ratings
  5. Severity mapping guides issue classification (Critical/Major/Minor)

Output Artifacts:

Review findings with DT-specific quality criteria applied, including coaching tone assessment, fidelity enforcement, and stakeholder coverage evaluation.

Success Indicators:

  • Review findings reference DT-specific criteria (coaching tone, space fidelity, stakeholder coverage)
  • Anti-patterns are flagged with correct severity levels
  • Token budget compliance checked against artifact type thresholds

Testing

  • Ran /prompt-analyze against the file and addressed all 8 findings (1 Critical, 4 Major, 3 Minor)
  • Validated with prompt-builder evaluation subagent: 5 Pass, 0 Fail, 4 N/A
  • Plugin generation successful: npm run plugin:generate

Checklist

Required Checks

  • Documentation is updated (if applicable)
  • Files follow existing naming conventions
  • Changes are backwards compatible (if applicable)
  • Tests added for new functionality (if applicable)

AI Artifact Contributions

  • Used /prompt-analyze to review contribution
  • Addressed all feedback from prompt-builder review
  • Verified contribution follows common standards and type-specific requirements

Required Automated Checks

  • Markdown linting: npm run lint:md
  • Spell checking: npm run spell-check
  • Frontmatter validation: npm run lint:frontmatter
  • Skill structure validation: npm run validate:skills
  • Link validation: npm run lint:md-links
  • PowerShell analysis: npm run lint:ps

- add dt-rpi-review-context.instructions.md with quality criteria per artifact type
- include review checklist additions, anti-patterns table, and severity mapping
- register in design-thinking and hve-core-all collections
- regenerate plugin outputs

✨ - Generated by Copilot
@kavithasreenath kavithasreenath requested a review from a team as a code owner February 20, 2026 23:27
- align table columns after plugin generation and format:tables

✨ - Co-Generated by Copilot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(instructions): Create dt-rpi-review-context.instructions.md

1 participant