Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

Merge incremental mode append and delete actions into index refresh  #149

@pirz

Description

@pirz

Describe the issue

Adding support for enforcing append and delete during index refresh (i.e. "incremental" mode) is being done thru two parallel PRs:

In order to make these PRs move forward with least conflicts, we decided to follow below steps:

  • Step 1. Do not make changes in refresh API and protect each action under a separate temporary Spark configuration flag. To keep current behavior of refresh intact, the flag for each of the actions is disabled by default.
  • Step 2. Let the PRs be reviewed, tested and merged to master.
  • Step 3. Refactor refresh index code and merge above actions as a subsequent step.

This issue is created to track the 3rd step above.

Expected behavior

Refresh index code in the smart mode should support both append and delete. This means once refreshIndex(mode = "smart") is called, Hyperspace should detect both additional and deleted source files and updates the index as expected for the smart mode.

Environment

All.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions