This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Optimize Index, with "quick" and "full" modes #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rahul Potharaju <rapoth@microsoft.com>
RefreshIncremental.scala is for the same purpose.
# Conflicts: # src/main/scala/com/microsoft/hyperspace/index/IndexLogEntry.scala # src/test/scala/com/microsoft/hyperspace/index/IndexLogEntryTest.scala
….scala Co-authored-by: Terry Kim <yuminkim@gmail.com>
….scala Co-authored-by: Terry Kim <yuminkim@gmail.com>
…s.scala Co-authored-by: Terry Kim <yuminkim@gmail.com>
Contributor
|
LGTM, Thanks @apoorvedave1 |
…optimize # Conflicts: # src/main/scala/com/microsoft/hyperspace/actions/OptimizeAction.scala # src/test/scala/com/microsoft/hyperspace/index/IndexManagerTests.scala
apoorvedave1
commented
Oct 13, 2020
imback82
reviewed
Oct 13, 2020
src/main/scala/com/microsoft/hyperspace/actions/OptimizeAction.scala
Outdated
Show resolved
Hide resolved
imback82
reviewed
Oct 13, 2020
src/main/scala/com/microsoft/hyperspace/actions/OptimizeAction.scala
Outdated
Show resolved
Hide resolved
imback82
reviewed
Oct 13, 2020
src/main/scala/com/microsoft/hyperspace/actions/OptimizeAction.scala
Outdated
Show resolved
Hide resolved
….scala Co-authored-by: Terry Kim <yuminkim@gmail.com>
imback82
reviewed
Oct 13, 2020
src/main/scala/com/microsoft/hyperspace/actions/OptimizeAction.scala
Outdated
Show resolved
Hide resolved
imback82
reviewed
Oct 13, 2020
src/main/scala/com/microsoft/hyperspace/actions/OptimizeAction.scala
Outdated
Show resolved
Hide resolved
imback82
reviewed
Oct 13, 2020
src/main/scala/com/microsoft/hyperspace/index/IndexManager.scala
Outdated
Show resolved
Hide resolved
imback82
reviewed
Oct 13, 2020
Collaborator
|
LGTM Thanks @apoorvedave1 |
imback82
approved these changes
Oct 14, 2020
Contributor
imback82
left a comment
imback82
left a comment
There was a problem hiding this comment.
LGTM, thanks @apoorvedave1!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
NOTE TO REVIEWERS: This PR doesn't handle the scenario where all index files are already optimized and we can make the optimize a NO-Op operation. Issue #204 will handle this case
What changes were proposed in this pull request?
Does this PR introduce any user-facing change?
How was this patch tested?