This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Add "appended" and "deleted" source files in index metadata #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
reviewed
Oct 8, 2020
src/main/scala/com/microsoft/hyperspace/index/IndexLogEntry.scala
Outdated
Show resolved
Hide resolved
imback82
approved these changes
Oct 8, 2020
Contributor
imback82
left a comment
imback82
left a comment
There was a problem hiding this comment.
LGTM, thanks @apoorvedave1!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES TO REVIEWERS:
Index metadata changes from another PR #170 by @pirz have been handpicked in this PR (with consent).
Changes include:
Reviewers are NOT required to review PR Update index log entry for enforce delete during read time #170 to review this PR.
What is the context for this pull request?
What changes were proposed in this pull request?
add "appended" and "deleted" files fields in Source data content in index metadata.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
index metadata json test