This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Appended files should look at modified time and file size for comparison #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into errorhandling
…into bugfixes # Conflicts: # src/test/scala/com/microsoft/hyperspace/TestUtils.scala
Co-authored-by: Terry Kim <yuminkim@gmail.com>
Co-authored-by: Terry Kim <yuminkim@gmail.com>
…into errorhandling
# Conflicts: # src/main/scala/com/microsoft/hyperspace/actions/RefreshDeleteAction.scala # src/test/scala/com/microsoft/hyperspace/index/RefreshIndexTests.scala
apoorvedave1
changed the title
sezruby
reviewed
Oct 10, 2020
| val relation = previousIndexLogEntry.relations.head | ||
| val originalFiles = relation.data.properties.content.fileInfos | ||
|
|
||
| val currentFiles = df.queryExecution.optimizedPlan |
Collaborator
There was a problem hiding this comment.
Could you extract this as protected lazy val and use it for both appendedFiles and deletedFiles?
Collaborator
|
Closed by #207 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182
Note For Reviewers: This is a low priority non-blocker issue. It's very rare that users will replace data files with exact data files with same name and modified content. But still, for correctness, it can be picked as time allows
What is the context for this pull request?
What changes were proposed in this pull request?
Please refer #182
Does this PR introduce any user-facing change?
How was this patch tested?