This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Refactor Hybrid Scan test suites #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
Author
sezruby
force-pushed
the
hybridtest_refactoring
branch
from
36359fa to
ea65e60
Compare
Contributor
Can we do this as a separate PR? There are rename / changes, so diff is too big to review. |
sezruby
force-pushed
the
hybridtest_refactoring
branch
from
ea65e60 to
f9cdef5
Compare
sezruby
commented
Jan 8, 2021
| assert(basePlan.equals(join.queryExecution.optimizedPlan)) | ||
| // Check if the given plan is transformed correctly to handle deleted files. The plan | ||
| // should include only one LogicalRelation node which is transformed with the given index. | ||
| def checkDeletedFiles( |
Collaborator
Author
There was a problem hiding this comment.
Note to reviewers: Instead of checking the transformed plan in every test, I introduced following functions to check the transformed plan properly.
def checkFilterIndexHybridScanUnion( // for filter rule
def checkJoinIndexHybridScan( // for join rule
def checkDeletedFiles( // check the deleted files for both filter & join HybridScanSuite contains general testcases for all non-partitioned/partitioned/delta lake dataset.
Dataset-specific tests are located in each test class.
imback82
approved these changes
Jan 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
What changes were proposed in this pull request?
This PR refactors Hybrid Scan test suites.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests