This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Support incremental refresh for Delta Lake #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezruby
changed the title
imback82
reviewed
Jan 7, 2021
| * @param relation [[Relation]] object to read partial data files. | ||
| * @return File format to read partial data files. | ||
| */ | ||
| def partialReadFileFormat(relation: Relation): Option[String] |
Contributor
There was a problem hiding this comment.
I think this should be def internalFileFormatName, underlyingFileFormatName, physicalFileFormatName or something to denote the actual file format used for storing the files?
Contributor
|
@apoorvedave1 @pirz Can you review this PR? Thanks. |
apoorvedave1
previously approved these changes
Jan 13, 2021
Contributor
apoorvedave1
left a comment
apoorvedave1
left a comment
There was a problem hiding this comment.
LGTM, thanks @sezruby
pirz
previously approved these changes
Jan 13, 2021
| logicalRelation.relation match { | ||
| case HadoopFsRelation(_: PartitioningAwareFileIndex, _, _, _, format, _) | ||
| if isSupportedFileFormat(format) => | ||
| if isSupportedFileFormat(format) => |
Contributor
There was a problem hiding this comment.
nit: Is indentation here correct?
Collaborator
Author
There was a problem hiding this comment.
yes it's fixed by scalafmt; it's because this if is for the case.
imback82
approved these changes
Jan 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
Fixes #295
What changes were proposed in this pull request?
This PR includes following bug fixes for Delta Lake source.
partialReadFileFormatto read appended files separatelyDoes this PR introduce any user-facing change?
Yes, this PR fixes several issues described above.
How was this patch tested?
Unit test