This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Build magic docs #113
Merged
Build magic docs #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmshaffer
previously approved these changes
Apr 8, 2020
src/Jupyter/Extensions.cs
Outdated
Comment on lines
174
to
176
| internal static string TrimLeadingWhitespace(this string s) => | ||
| new Regex(@"^\s+", RegexOptions.Multiline) | ||
| .Replace(s, string.Empty); |
Contributor
There was a problem hiding this comment.
Is there a difference between this and the built-in string.TrimStart()? Also, maybe I'm missing it but I don't see anywhere in this PR where this is used?
Contributor
Author
rmshaffer
approved these changes
Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new
%lsmagiccommand that lists magic commands in a discoverable fashion, extracts magic symbol resolution into a new service, and then uses this new functionality to automatically build an API reference for all existing magic commands. This PR also integrates the new functionality into CI, so that the generated magic command docs can be incorporated into an existing docset as a part of CI pipelines.Marked as WIP for early feedback and in lieu of testing CI support. (Update: CI testing complete, this should now be ready for review.)