Initial IQ# magic command implementation for Azure Quantum #144
Conversation
efratshabtai
left a comment
efratshabtai
left a comment
There was a problem hiding this comment.
Something to think about is what would the experience be for users that are not part of the private preview.
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
Looks good to me! I think there's some comments that would be good to address before merging, but I'm happy to trust your judgment on those.
|
@efratshabtai @cgranade Apologies for all of the messy comments and replies, I was using CodeFlow to respond to these comments and it apparently adds hashtags to your comments when I change the status of them, creates orphaned replies, doesn't handle suggestions appropriately, etc... I'll be sticking to GitHub for PR comments from now on... |
I imagine that users who aren't part of the preview won't be able to create Azure Quantum workspaces, and therefore they won't be able to pass a valid workspace name to %connect (or, later, %aq connect). We do make clear in the resulting error message that the specified workspace must be an Azure Quantum workspace. |
This PR targeting
feature/azure-quantum-previewcontains the initial implementation of%connect,%status,%submit, and%targetmagic commands for Azure Quantum integration from IQ#, along with associated test code.This is a rather large PR, but since everything is so interconnected, it made sense to allow someone to review all of the pieces at once to get the big picture.
There are a number of aspects about the design, user experience, argument parsing, etc. that are not yet final or not yet implemented, but all of these should be relatively minor changes and will be done incrementally. The overall structure here should be stable.
There are additional magic commands planned, which will follow in later PRs. This one is already big enough. Subsequent PRs will be much smaller and more targeted.